Pascal Pfiffner

Results 97 comments of Pascal Pfiffner
trafficstars

I see. I would experiment with [these lines](https://github.com/smart-on-fhir/Swift-FHIR/blob/3032da9e3ae096db5b6e1bfee8ed69391e16c4bd/Sources/Client/Reference%2BResolving.swift#L64-L70); I'd probably do an `else` after this block (which will fail since there's no `fullUrl`) and compare `refUrl` (which is still `Type/id`...

Nice catch, and not intentional; shows the desolate state the SMART specific test cases are in! The instruction to wait for the block callback is also missing, I don't think...

Ah great! Yes, that makes sense. The client works by reading the Conformance statement the first time any REST call is needed, so for open servers you may only need...

Seems to be some issue surfacing due to recent compiler optimizations. Turn on "Thread Sanitizer" to avoid it.

This depends on the server, which is free to require `If-Match`. Would be nice if the client added this header if a versionId is found.

Yes, thanks! Also to have it documented: the Swift-FHIR framework now solves this by providing custom classes/structs for primitives. Those can handle extensions (and ids), as opposed to the native...

The files in `Sources/Models` are generated from files and templates in `fhir-parser-resources`; the templates will need to be updated. 😬

You mean you'd like to have a way to specify `_include` and `_revinclude`? That is certainly a good idea and I'm open to suggestions! On a related note, resolving references...

The `Resource.where()` method returns a `FHIRSearch` instance. Yes, would be feasible to add an `include()` method to that class to support this notion, then one could call `perform(server)` to execute...

Yes; the current implementation is very cheap and simply [uses `isodate.parse_date[time]`](https://github.com/smart-on-fhir/client-py/blob/master/fhirclient/models/fhirdate.py#L31-L34).