Povilas Kanapickas

Results 230 comments of Povilas Kanapickas

> If you prefer, I can add a commit that runs Black and applies the changes it wants to make. I ran `ruff format .` after rebasing, no need to...

@mokeyish Tests in pytests/test_container_to_args.py don't actually run any containers. The test structure is as follows: - create compose definition in parsed form (i.e. python dicts, lists, etc. are used) -...

So in GPU tests I would expect tests that check whether correct GPU-related options are added to podman_args.

The feature request makes sense. Feel free to open a PR.

I looked into this again and think that we could simply have a unit test for `get_secret_args` function. We already have tests for `container_to_args()` in `pytests/test_container_to_args.py`. At the moment splitting...

Merged via https://github.com/containers/podman-compose/pull/971 which added unit tests. Thanks for the PR that did most of the work.

@rtgiskard Would you still be open to push this PR to completion? It mostly needs a rebase, as some of the fixes have already been applied; and unit tests, as...

@paulmillar Are you still using podman-compose on bullseye? I would be open to supporting bullseye version of podman if someone would be willing to setup testing in bullseye and fix...

Closing as per reason given by Pierre: > I don't think it is reasonable to merge it if it requires a twisted patch

Please resubmit this PR against buildbot repository.