Roman

Results 85 comments of Roman

We are _suppossed to_ clean up resources in this function: https://github.com/osmosis-labs/osmosis/blob/fd23552f94caf1df9dbeb6fb4784e9d0efded2a4/tests/e2e/containers/containers.go#L288-L299 On a quick look, it seems that the call to this function is [still there](https://github.com/osmosis-labs/osmosis/blob/fd23552f94caf1df9dbeb6fb4784e9d0efded2a4/tests/e2e/e2e_setup_test.go#L110). Is there a chance...

It seems that the containers are not getting cleared if stopped mid-way through the execution. However, if run until the end, the existing logic takes care of the removal. So...

Hi @rrrliu . Great work on this PR! Just wanted to check in and see if you have time to address the last 2 suggestions. We can merge this right...

@rrrliu thanks and np! Seems that there is a CI failure due to merge conflict, do you mind fixing that test, please? We can merge this right after

I briefly looked into this: https://github.com/osmosis-labs/osmosis/blob/fe98f6e4453cd32035d277c21ef2f3669b677bb2/osmoutils/parse.go#L61 I don't see a way to parse a yml file, only json. I think the goal of this issue is to make it possible...

> > > Is there a reason we removed the `Require` statements? > > > > > > to reduce verbosity, said p0mvn > > I'm not following? How does...

> Sorry, I'm actually generally confused about whats going on in these governance proposal routing. > > My understanding is that in the today code, replace incentives proposal works on...

Hi @catShaark . I just would like to confirm that you've gotten a chance to manually test that both pool incentives proposals are functioning as expected. Please let me know

I think it would be great to have an e2e test for submitting these pool-incentive proposals. Would you be interested in adding it?