Patrik Schönfeldt

Results 95 issues of Patrik Schönfeldt

This PR removes large chunks of code that is hard to maintain (and mostly abandoned unmaintained). As the code is partly covered by (integration-) tests, this will reduce the measured...

maintenance

- [X] Rename `PERIODS` to `CAPACITY_PERIODS` (The former can be easily confused with aggregation periods.) - [X] Remove lifetime/age tracking. - [x] Remove difference between fixed costs and periodical costs...

The values for min or max of the content of a `GenericStorage` are not considered in solph v0.5 if there is an investment for the storage capacity. (Everything is fine...

bug
triaged

This adds a drop-in replacement for `processing.results` that uses the new `solph.Results` class. It means to provide backwards compatibility while radically simplifying the processing code.

enhancement

While you can use NonConvex to model really non-convex things, it is often just used for non-continuous variables (`v = m * b, 0

Simplify indexes in the TSAM compatible version (esp. removing the current multi-period investment). - [x] If we have time dependent capacities with investments, it would be reasonable to also have...

**Describe the bug** Investment to bidirectional Flow leads to an infeasibility. **To Reproduce** See script at https://gist.github.com/p-snft/6106ec8727c78928d2b541afe5ef7501 **Expected behavior** Capacity should be optimised (to set minimum) if investment problem is...

bug

I've recently seen typos there, esp. `model.solve(solver_kwargs={})`. We should remove the catch-all **kwargs as well. (Was done almost everywhere before.) https://github.com/oemof/oemof-solph/blob/749e85aa7ecd6c73982e8479265cdc5164e67717/src/oemof/solph/_models.py#L392

The API of `solph.Results` feels a bit like a dictionary. With that in mind, there are two possible improvements: * results["objective"] does not exist (but only results.objective). The former is...

* Adds unit test to reveal the problem described in #1237. * Removes `Results.__getattr__(..)` to fix it. * Removes other properties and replaces them with dict-like access. This by the...

bug