csv2 icon indicating copy to clipboard operation
csv2 copied to clipboard

qt types compatibility

Open ntfshard opened this issue 5 years ago • 5 comments

Hello

Is it make sense to prepare pull request with Qt types support? (or at least try to do it) I believe sfinae magic should be enough for this. Or library should be stl compatible only? Asking just for saving our time)

ntfshard avatar Nov 04 '20 00:11 ntfshard

What Qt types are you talking about here. As Qt is dependent on C++ so all types will work except std::string which anyway you can convert it to QString by using fromStdString method.

sonulohani avatar Jan 30 '21 13:01 sonulohani

What Qt types are you talking about here. As Qt is dependent on C++ so all types will work except std::string which anyway you can convert it to QString by using fromStdString method.

Yep, but it doesn't look elegant. To open file may be it's fine to use toStdString method. It will be called only once. But you can't call cell.read_value(qstringobject), you should use std::string and copy value to qString Moreover I noticed some weird issues with non-ascii symbols in patch -- it leads to crash. And one more, it looks like implementation not satisfy rfc4180 5.2

ntfshard avatar Jan 31 '21 21:01 ntfshard

I dont know if the devs are even active here. We can have the fork of this repo to work on the bugs.

sonulohani avatar Feb 01 '21 04:02 sonulohani

Or use other from fffaraz/awesome-cpp#csv repo

ntfshard avatar Feb 01 '21 10:02 ntfshard

Or use other from fffaraz/awesome-cpp#csv repo

You could use other. But their could be subtle difference between these libraries. For fast parsing, csv2 is the best.

sonulohani avatar Feb 06 '21 06:02 sonulohani