pquic icon indicating copy to clipboard operation
pquic copied to clipboard

Incorrect way of prunning the retransmission queue.

Open QUICTester opened this issue 1 year ago • 2 comments

Hi, During testing commit https://github.com/p-quic/pquic/commit/841c82289b23d32c28723a0175654ecc6baeae08, we discovered that the PQUIC server uses Picoquic code that does not correctly prune the retransmission queue in picoquic/sender.c:picoquic_implicit_handshake_ack().

The pruning direction on the retransmission queue is opposite to how the packets are added in picoquic/sender.c:picoquic_queue_for_retransmit().

Therefore the picoquic_packet_t* p_next = p->next_packet; in picoquic/sender.c:picoquic_implicit_handshake_ack() should be picoquic_packet_t* p_next = p->previous_packet;

QUICTester avatar Aug 28 '23 09:08 QUICTester

Could you test #39 as a potential fix ?

mpiraux avatar Oct 04 '23 06:10 mpiraux

Yes, it does not have any problem anymore when we test.

QUICTester avatar Oct 28 '23 13:10 QUICTester