P icon indicating copy to clipboard operation
P copied to clipboard

Upgraded project files to .NET 6

Open dasblinkenlight opened this issue 3 years ago • 10 comments

  • Updated nuget dependencies
  • Worked around VS 2022's finding antlr-generated code twice
  • Updated unit test template project to use .NET 6

dasblinkenlight avatar Jul 09 '22 14:07 dasblinkenlight

I verified that the code compiles and all 320 unit tests pass on a Mac M1 hardware running arm64 .NET 6.0.6.

dasblinkenlight avatar Jul 09 '22 14:07 dasblinkenlight

I pushed a fix for the failing build items to my fork. Do I need to do anything else to have the system re-run the CI?

dasblinkenlight avatar Jul 12 '22 18:07 dasblinkenlight

Ubuntu tests appear to be stuck. Is there any visibility into what's happening?

dasblinkenlight avatar Jul 12 '22 20:07 dasblinkenlight

...I guess it died again, I don't know what's going on. The other two platforms finished w/no issues on the first try.

dasblinkenlight avatar Jul 13 '22 02:07 dasblinkenlight

Let's see if the third change fixes the hang.

dasblinkenlight avatar Jul 13 '22 15:07 dasblinkenlight

The workflow is not running, could you please approve the rerun?

dasblinkenlight avatar Jul 14 '22 16:07 dasblinkenlight

@ankushdesai Is there a way to see what CI on Ubuntu is doing? It looks like it is hitting the same problem again, but there's no log in the [Details] link to see how far we've made it through the unit tests. The little triangle was there initially, but after a while it has just disappeared. Are we hitting some sort of a time limit for the job? Didn't you run into a similar issue when you tried to upgrade to .NET 5 several months ago?

dasblinkenlight avatar Jul 14 '22 18:07 dasblinkenlight

Hi @dasblinkenlight, it seems like there is a bug in the PR. I will look into this tomorrow or on Monday and get back to you.

ankushdesai avatar Jul 14 '22 23:07 ankushdesai

@ankushdesai There's a chance that it has to do with me upgrading to Coyote 1.7.5. When I rolled it back to 1.0.5 the tests ran much faster on my computer. I think after the rollback the CI will run faster - at least on Mac and Windows (two successful runs took 44 minutes to an hour, vs. the more common 15..20 minutes).

dasblinkenlight avatar Jul 15 '22 01:07 dasblinkenlight

@ankushdesai Could you please approve a rerun to see if rolling back to the current version of Coyote fixes the problem?

dasblinkenlight avatar Jul 21 '22 14:07 dasblinkenlight

Moving to .net6 would also require upgrading to coyote that supports version .net6.0. Your changes by itself wont work. We working on porting P to .Net6 and will release the new version in a couple of weeks. Thanks for the help!

ankushdesai avatar Oct 22 '22 07:10 ankushdesai