Support for Z shell

[shellkr]

Right now Finalterm only supports Bash which is good as it is the most popular shell.. but Zsh is also popular and should be possible to use. Zsh offer a lot of improvements over Bash.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

[p-e-w]

I agree, though that will probably only happen after Final Term (with bash) is fully stable. But I definitely intend to support all major shells in the future.

[nerzhul]

I approve @Almehdi i use zsh every time and unfortunately i cannot use this very good terminal emulator with ZSH because the cursor is at the begin of the line, not after the prompt :s

[super-nathan]

frankly was trying to build this until I saw no ZSH,

:(

[p-e-w]

Please be patient, folks :)

I'll revisit zsh once Final Term works properly with bash.

[nerzhul]

This problem is also present when we do a SSH session on a server with zsh :(

[ghost]

@p-e-w Does "all major shells" include fish?

[p-e-w]

@Alyxr: It does, to me at least :)

See https://github.com/p-e-w/finalterm/issues/44

[nerzhul]

Maybe you must change your terminal approach because of variety of shells ?

[tsdh]

What is finalterm concerned about what shell it's running? The output of commands is the same in every shell, or does it interact more with the shell than parsing the output of known commands?

IMHO, if it was possible, I'd welcome if it just runs whatever SHELL the user has set. Feel free to state explicitly that it might break with everything except bash, but I'd still be able to run my beloved, highly configured ZSH.

[tsdh]

Ah, ok, I've just seen that no feature making finalterm innovative works when I start a zsh manually. Do you have some pointers/docs on what's needed to make it work with other shells?

[p-e-w]

@tsdh: What's needed to make another shell work with Final Term is a startup script along the lines of https://github.com/p-e-w/finalterm/blob/master/data/Startup/bash_startup that injects the custom control sequences that tell Final Term what is going on inside the shell.

[masnormen]

Still waiting 'till the Final Term is fully stable! I can't wait for the Final Term with Zsh support! :D

[brodock]

+1

[Cosmicist]

+1! I just tried finalterm and zsh + finalterm would make for a hell of a nerdgasm :P

[StuntsPT]

Just to add my +1 to have zsh support in finalterm. =-)

[Malsasa]

+1 zsh support after Finalterm with bash was stable.

[aboutaaron]

:thumbsup: I also would love finalterm with ZSH support.

[NelsonBrandao]

:+1:

[p-e-w]

With the most recent changes, zsh support has become a much closer goal than it was before. Please see http://blog.finalterm.org/2014/01/the-marriage-of-terminal-and-shell.html for some details.

[gamesbrainiac]

+1 This would be a highly appreciated feature

[LightGuard]

:+1:

[qwc]

:+1: bump FinalTerm looks nice, feels nice, but is not usable with zsh for time being. At least with my configuration (includes oh-my-zsh).

[mjacobus]

If you open a normal teminal, attach it to temux and then open finalterm, and attach to that same session you will have zshell inside finalterm.

[nerzhul]

@mjacobus very hard whereas there is an option to change finalterm default shell into dconf (which doesn't work)

[detiber]

I've started to take a crack at adding zsh support here: https://github.com/detiber/finalterm/tree/zsh

So far I'm able to load finalterm using zsh as the shell, but the context menus aren't currently working properly (nor is wget progress). Any comments/suggestions are greatly appreciated.

Bootstrapping steps are here: https://github.com/detiber/finalterm/blob/zsh/README-ZSH.md

I've also started a copr build (for fedora/centos/rhel users) here: https://copr.fedoraproject.org/coprs/jdetiber/finalterm-zsh/

[lwandrebeck]

Termlets are bash-centric (start with #!/bin/bash), that may explain why it doesn’t work. We’d need to split them shell by shell to use their own internals for speed, imho. See #338 :)

[detiber]

@lwandrebeck indeed, I didn't get a chance to dig into the Termlets too much (other than calling out to them using zsh, and updating them to autoload functions if $ZSH_VERSION is set).

When I get some more time to hack on it I'll work on implimenting them in a zsh compatible way. I was mostly happy to have abstracted out the bashisms that were preventing zsh from even loading as the default shell.

I submitted a https://github.com/p-e-w/finalterm/pull/355 to help solicit better feedback on the changes I've made so far.

[tuxayo]

:+1: That would be a killer combo