fix: prevent exception in logs when using base64 image

[vaab]

In the logs:

journalctl --user -f | grep -i gnome-shell

I get:

Unable to load image from Base64 representation: TypeError: this.child_set_property is not a function

On each update. My menu contains a base64 image.

I don't know gnome at all, but I feel that my replacement suggestion has the same intent. I didn't notice any breaking on my side.

Do you want a minimal reproducing case ?

[mwilck]

Why are you using a base64 image? I have to admint I hear this term for the first time.

I don't know gnome at all, but I feel that my replacement suggestion has the same intent.

Thanks for being honest, but this doesn't sound convincing. Please provide links in to the documentation.

[mwilck]

Seems related to #151

[mwilck]

Ok, so BoxLayout inherits set_y_expand() from ClutterActor. I'm inclined to merge this.

[vaab]

I don't now what was the original intent, this is why I'm unsure about the fix. I was hoping that you would know ;-). The arcane of image and sizing is somewhat subtle (broken?) also, so I just tried to do my best to translate the intent into more modern gnome ways. I'd love to be able to know how to test what this line does exactly, but I didn't see any changes with or without in my case... :-(

As for the base64 image, well, isn't it the only way to include images ? I'm all the happier if there's another way... Here's the doc:

Attribute	Value	Description
image, templateImage	Base64-encoded image file	Renders an image inside the item. The image is positioned to the left of the text and to the right of the icon. GNOME Shell does not have a concept of "template images", so image and templateImage are interchangeable in Argos.

Thanks for your review.