pg-structure icon indicating copy to clipboard operation
pg-structure copied to clipboard
verified publisher icon ozum

keepConnection should be true by default if pg.Client or pg.Pool is passed

Open andreypopp opened this issue 3 years ago • 1 comments

Hi,

Thanks for the pg-structure!

Just some feedback on API ergonomics. I think it would make API more ergonomic if pg-structure would keep connections open if it passed pg.Client or pg.Pool — the justification is that if a user passed an initialised connection then they are responsible for its lifecycle.

andreypopp avatar Feb 16 '22 11:02 andreypopp

Thanks for the suggestion.

ozum avatar Feb 18 '22 13:02 ozum