file.d icon indicating copy to clipboard operation
file.d copied to clipboard

fix some linters issue

Open sashamelentyev opened this issue 3 years ago • 5 comments

Description

Fix some linters issue, but not all. We can stay open this issue. Or close and create new next time

Fixes #198

sashamelentyev avatar Sep 07 '22 14:09 sashamelentyev

Your new linter failed lint:

prepare environment
run golangci-lint
  Running [/home/runner/golangci-lint-1.45.2-linux-amd64/golangci-lint run --out-format=github-actions --new-from-patch=/tmp/tmp-1620-fWKuP0XhAj4q/pull.patch --new=false --new-from-rev= --timeout 5m] in [] ...
  level=error msg="Running error: unknown linters: 'usestdlibvars', run 'golangci-lint help linters' to see the list of supported linters"
  
  Error: golangci-lint exit with code 3
  Ran golangci-lint in 1616ms

ansakharov avatar Sep 07 '22 16:09 ansakharov

Your new linter failed lint:

prepare environment
run golangci-lint
  Running [/home/runner/golangci-lint-1.45.2-linux-amd64/golangci-lint run --out-format=github-actions --new-from-patch=/tmp/tmp-1620-fWKuP0XhAj4q/pull.patch --new=false --new-from-rev= --timeout 5m] in [] ...
  level=error msg="Running error: unknown linters: 'usestdlibvars', run 'golangci-lint help linters' to see the list of supported linters"
  
  Error: golangci-lint exit with code 3
  Ran golangci-lint in 1616ms

I update golangci-lint

sashamelentyev avatar Sep 07 '22 16:09 sashamelentyev

@sashamelentyev, thanks for this contribution!

Can we hardcode golangci-lint version in the Makefile too? For example:

.PHONY: lint
lint:
	# installation: https://golangci-lint.run/usage/install/#local-installation
	golangci-lint run --new-from-rev=${UPSTREAM_BRANCH}

->

.PHONY: lint
lint:
	go run github.com/golangci/golangci-lint/cmd/[email protected] run --new-from-rev=${UPSTREAM_BRANCH}

vadimalekseev avatar Sep 08 '22 13:09 vadimalekseev

@vadimalekseev done

sashamelentyev avatar Sep 08 '22 13:09 sashamelentyev

@ansakharov @vadimalekseev can we merge this?

sashamelentyev avatar Sep 14 '22 07:09 sashamelentyev