file.d
file.d copied to clipboard
fix some linters issue
Description
Fix some linters issue, but not all. We can stay open this issue. Or close and create new next time
Fixes #198
Your new linter failed lint:
prepare environment
run golangci-lint
Running [/home/runner/golangci-lint-1.45.2-linux-amd64/golangci-lint run --out-format=github-actions --new-from-patch=/tmp/tmp-1620-fWKuP0XhAj4q/pull.patch --new=false --new-from-rev= --timeout 5m] in [] ...
level=error msg="Running error: unknown linters: 'usestdlibvars', run 'golangci-lint help linters' to see the list of supported linters"
Error: golangci-lint exit with code 3
Ran golangci-lint in 1616ms
Your new linter failed lint:
prepare environment run golangci-lint Running [/home/runner/golangci-lint-1.45.2-linux-amd64/golangci-lint run --out-format=github-actions --new-from-patch=/tmp/tmp-1620-fWKuP0XhAj4q/pull.patch --new=false --new-from-rev= --timeout 5m] in [] ... level=error msg="Running error: unknown linters: 'usestdlibvars', run 'golangci-lint help linters' to see the list of supported linters" Error: golangci-lint exit with code 3 Ran golangci-lint in 1616ms
I update golangci-lint
@sashamelentyev, thanks for this contribution!
Can we hardcode golangci-lint version in the Makefile too? For example:
.PHONY: lint
lint:
# installation: https://golangci-lint.run/usage/install/#local-installation
golangci-lint run --new-from-rev=${UPSTREAM_BRANCH}
->
.PHONY: lint
lint:
go run github.com/golangci/golangci-lint/cmd/[email protected] run --new-from-rev=${UPSTREAM_BRANCH}
@vadimalekseev done
@ansakharov @vadimalekseev can we merge this?