poiji icon indicating copy to clipboard operation
poiji copied to clipboard

Write to Excel Feature

Open minneakhmetov opened this issue 2 years ago • 3 comments

This PR does not pretend to be merged. It is suggestion how to implement writing a collection of POJOs to Excel Sheet using only one line of code. The demo of usage my code is in tests. Now annotation @ExcelCellName is only supported. Please, be kind to review and comment.

minneakhmetov avatar Apr 08 '22 17:04 minneakhmetov

Hi @saiple , thank you for contributing to Poiji :) I will review your changes

ozlerhakan avatar Apr 08 '22 20:04 ozlerhakan

Codecov Report

Merging #235 (856e58c) into master (65a9395) will decrease coverage by 2.79%. The diff coverage is 44.44%.

@@             Coverage Diff              @@
##             master     #235      +/-   ##
============================================
- Coverage     92.76%   89.97%   -2.80%     
- Complexity      433      441       +8     
============================================
  Files            43       44       +1     
  Lines          1175     1247      +72     
  Branches        147      163      +16     
============================================
+ Hits           1090     1122      +32     
- Misses           51       88      +37     
- Partials         34       37       +3     
Impacted Files Coverage Δ
src/main/java/com/poiji/config/DefaultCasting.java 75.13% <11.90%> (-19.11%) :arrow_down:
src/main/java/com/poiji/bind/PoijiWriter.java 88.46% <88.46%> (ø)
src/main/java/com/poiji/bind/Poiji.java 97.26% <100.00%> (+0.15%) :arrow_up:

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

codecov-commenter avatar May 13 '22 19:05 codecov-commenter

Hi @minneakhmetov ,

When do you think you're done?

ozlerhakan avatar Aug 18 '22 10:08 ozlerhakan

It has been a long while that the PR is getting old without changes. I'm closing it feel free to make changes we can open it up again.

ozlerhakan avatar Nov 02 '22 18:11 ozlerhakan