embedded-redis icon indicating copy to clipboard operation
embedded-redis copied to clipboard

Update redis binaries

Open jameshilliard opened this issue 4 years ago • 11 comments

It seems we also need to update our dependencies for this to work correctly.

Note that for the OSX/Linux binaries I've taken care to ensure that they are highly portable unlike those in #15 by statically linking all libraries other than libSystem on OSX which is not really possible to statically link but should always be included. Windows is untested at this point and version 5.0.9 seems to be the latest native Windows binary available.

$ file src/main/resources/redis-server-6.0.5
src/main/resources/redis-server-6.0.5: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), statically linked, stripped
$ file src/main/resources/redis-server-6.0.5-32 
src/main/resources/redis-server-6.0.5-32: ELF 32-bit LSB executable, Intel 80386, version 1 (SYSV), statically linked, stripped
$ otool -L src/main/resources/redis-server-6.0.5.app
src/main/resources/redis-server-6.0.5.app:
	/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1281.0.0)

jameshilliard avatar Jul 01 '20 03:07 jameshilliard

Codecov Report

Merging #16 into master will increase coverage by 0.46%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #16      +/-   ##
============================================
+ Coverage     72.81%   73.28%   +0.46%     
  Complexity      116      116              
============================================
  Files            20       20              
  Lines           515      509       -6     
  Branches         38       38              
============================================
- Hits            375      373       -2     
+ Misses          118      114       -4     
  Partials         22       22              
Impacted Files Coverage Δ Complexity Δ
...rc/main/java/redis/embedded/RedisExecProvider.java 100.00% <100.00%> (ø) 9.00 <1.00> (ø)
...ain/java/redis/embedded/AbstractRedisInstance.java 86.56% <0.00%> (-0.39%) 14.00% <0.00%> (ø%)
src/main/java/redis/embedded/util/OSDetector.java 20.83% <0.00%> (+1.60%) 3.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 659f4ba...3f1a275. Read the comment docs.

codecov-commenter avatar Jul 01 '20 03:07 codecov-commenter

Please also add 5.0.9 binaries for windows from https://github.com/tporadowski/redis/releases

mrniko avatar Oct 01 '20 07:10 mrniko

@mrniko Should be there already, note I have not tested the Windows version as I do not have a suitable dev environment set up at the moment for Windows.

jameshilliard avatar Oct 01 '20 07:10 jameshilliard

@jameshilliard

I did. It works fine

mrniko avatar Oct 01 '20 07:10 mrniko

Hi guys. Is there anything else to be done with this PR? I could help with testing, though only on linux system...

AlexeyNezhdanovGardena avatar May 10 '21 12:05 AlexeyNezhdanovGardena

Hi guys, would appreciate if you could update Mac OSX binaries to redis >= 6.0.10 as this version includes a fix for a bug that crashes redis on Mac ARM (M1) platforms.

Details can be found here: https://github.com/redis/redis/issues/8062

0kommanix avatar Jun 30 '21 07:06 0kommanix

Thank you so much for this PR. Although not released, I was able to use your binaries and override Redis for my tests that rely on features of recent Redis versions.

radarsh avatar Jul 19 '21 23:07 radarsh

Hi guys, would appreciate if you could update Mac OSX binaries to redis >= 6.0.10 as this version includes a fix for a bug that crashes redis on Mac ARM (M1) platforms.

Details can be found here: redis/redis#8062

Any update regarding upgrading redis version to >= 6.0.10? Thanks.

kenshinji avatar Jan 26 '22 18:01 kenshinji

I don't know but appears this repository is dead, if we do create a redis-embedded organization and add all people with an PR opened in this repository? @kenshinji

ripper2hl avatar Feb 09 '22 21:02 ripper2hl

Any chance to get this merged and released? @ozimov

nikeee avatar Apr 22 '22 12:04 nikeee

https://github.com/signalapp/embedded-redis is a more up-to-date fork (Maven). It uses Redis 6.2.7.

nathanfranke avatar Jun 06 '22 05:06 nathanfranke