embedded-redis icon indicating copy to clipboard operation
embedded-redis copied to clipboard

Remove slf4j-simple from dependencies

Open pcimcioch opened this issue 4 years ago • 2 comments

slf4j-simple is logging implementation and it shouldn't be forced as library's transient, non-optional dependency. Adding slf4j-simple was quite disruptive, as it basically breaks applications that include this library but use other slf4j implementations (like logback). From what I can see, it should be enough to have commons-logging in dependencies, and slf4j-simple can be used for test dependencies.

pcimcioch avatar Jun 18 '20 15:06 pcimcioch

Codecov Report

Merging #14 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #14   +/-   ##
=========================================
  Coverage     72.81%   72.81%           
  Complexity      116      116           
=========================================
  Files            20       20           
  Lines           515      515           
  Branches         38       38           
=========================================
  Hits            375      375           
  Misses          118      118           
  Partials         22       22           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 659f4ba...3a21d3a. Read the comment docs.

codecov-commenter avatar Jun 18 '20 15:06 codecov-commenter

@robertotru any progress on this?

skjolber avatar Jan 22 '21 13:01 skjolber