tweet-image icon indicating copy to clipboard operation
tweet-image copied to clipboard

add calc() for all divisions and change some dependencies to devDependencies

Open 01231 opened this issue 4 years ago • 3 comments

01231 avatar Jan 04 '22 14:01 01231

Why do we need calc? It's already working without it.

ozgrozer avatar Jan 04 '22 14:01 ozgrozer

  1. you are already using calc() for some divisions (style.scss line 104 for example), but not for all. So this would be an improvement on the consistency.
  2. using / for division is deprecated for sass

01231 avatar Jan 04 '22 18:01 01231

I saw that you have these dependencies

"babel-core", "babel-preset-react":

and a .babelrc file, but I don't see them used. Are they being used?

01231 avatar Jan 04 '22 18:01 01231