georasters icon indicating copy to clipboard operation
georasters copied to clipboard

fix: load_tiff in README was undefined

Open culebron opened this issue 7 years ago • 7 comments

fix for #31

culebron avatar Mar 20 '18 07:03 culebron

Coverage Status

Coverage decreased (-0.09%) to 29.905% when pulling 7c81bf62bd05c27eba0b781a7136855257564d2f on culebron:master into e633a4e8d8d168fa2a6b55760f8b1832d3c8b274 on ozak:master.

coveralls avatar Mar 20 '18 07:03 coveralls

It may be better to just add **kwargs instead of options=None and options= options, no?

ozak avatar Mar 20 '18 13:03 ozak

Yes, good idea.

culebron avatar Mar 20 '18 17:03 culebron

Doesn't forcing a np.float64(ndv) force any dataset to become float, even the ones that are integers and so increasing file size?

ozak avatar Mar 21 '18 02:03 ozak

@ozak I didn't test this. I found out that integer numpy matrices can't have None in them, and for integer ones (like ASTER DEM) it's only necessary to have a maksed array, without ndv.

It starts being confusing. Let me see how to run tests.

culebron avatar Mar 23 '18 10:03 culebron

To see the effect of this np.float I would save an integer raster with and without the option to see the difference in size.

I'm not sure I understood what you meant with the last comments... When is None being assigned to a numpy array?

ozak avatar Mar 23 '18 12:03 ozak

Also, how would you have a masked array without an ndv?

ozak avatar Mar 23 '18 12:03 ozak