M3UAndroid icon indicating copy to clipboard operation
M3UAndroid copied to clipboard

Fix bug 190: Brightness & Volume gestures only work when controls are…

Open tungnk123 opened this issue 1 year ago • 5 comments

Fix bug 190: Brightness & Volume gestures only work when controls are are displayed

tungnk123 avatar Oct 02 '24 15:10 tungnk123

The touch areas are somewhat confusing.

  • The green area controls volume or brightness.
  • The red area is for toggling visibility.

There are overlapping areas, making it difficult for users to control volume/brightness or dismiss the mask. The red area is not visible on the mask, and the green area covers the red area beneath the mask, all scroll events are intercepted by the green area.

photo_2024-10-03_00-30-59 photo_2024-10-03_00-31-04 photo_2024-10-03_00-31-06 photo_2024-10-03_00-31-08

oxyroid avatar Oct 02 '24 16:10 oxyroid

Do you mean that the users are confused because the volume/brightness control area (green area) overlaps with the mask visibility toggle area (red area)? Shouldn't the mask only appear when users tap in the center of the screen, while swiping on the sides should adjust brightness and volume without showing the mask? And when swiping, users don't want the mask to appear and disrupt their experience, right? Could you pls suggest me some solution for this problem?

tungnk123 avatar Oct 03 '24 01:10 tungnk123

The user should be able to tap to show or hide the controls and swipe to adjust the volume and brightness, regardless of whether the controls are visible. Ensure some areas of the top layer remain empty to allow tap events to reach the bottom layer, and there’s no need to restrict the width of the bottom layer.

oxyroid avatar Oct 04 '24 01:10 oxyroid

And in other hands, the controls layer in the front of the gesture layer has also scroll event need to be consume in the center so that we can enter the EPG panel. So

  1. tap the any position to show and hide controls whatever the controls is visible or not.
  2. swap the left or right sides to control the volume and brightness whatever the controls is visible or not.
  3. swap the center area to expand the EPG panel whatever the controls is visible or not.

oxyroid avatar Oct 04 '24 01:10 oxyroid

@oxyroid I have just pushed the new commit. Could you pls check it for me pls? Thanks very much for these comments ❤

tungnk123 avatar Oct 06 '24 09:10 tungnk123