oxygen-git-client-addon icon indicating copy to clipboard operation
oxygen-git-client-addon copied to clipboard

Show unstaged modifications to submodules

Open jonathanhanna opened this issue 3 years ago • 6 comments

When a file in a submodule is modified, running git status in the parent repository will show that the submodule has been modified. image

GitHub Desktop also shows changes have been made: image

It would be helpful if Oxygen's Git plugin also showed modifications under Unstaged files.

jonathanhanna avatar Apr 29 '21 17:04 jonathanhanna

Hello,

I see... When the submodule has unstaged/staged resources we should present that marker file. We currently present it when new commits appear in the submodule.

AlexJitianu avatar May 04 '21 10:05 AlexJitianu

@AlexJitianu, are you talking about new commits in the local repo or remote repo of a submodule?

We currently present it when new commits appear in the submodule.

kirkilj avatar May 06 '22 19:05 kirkilj

When a new commit appears in the local repo. We were thinking to decorate the pull button when there are changes in the submodule's remote repo, but we didn't do it yet.

AlexJitianu avatar May 13 '22 05:05 AlexJitianu

I believe I requested or up voted that feature awhile ago. Our dev group received a Feature request thus week about getting notified when a submodule is ahead on the server. Besides the decoration, could there be a preference to also check submodules and perform a submodule update on the dialog you currently offer to pull changes when the remote is ahead?

kirkilj avatar May 14 '22 17:05 kirkilj

What does "getting notified when a submodule is ahead on the server" mean? Is this from the administrator's or from the tech writer's perspective? What I mean by that:

  • the admin perspective: there are new commits or new tags in the submodule repo. You want to be notified because you might need to bind the submodule to a newer tag.
  • the tech writer's perspective: an admin has bound the submodule to a newer tag and you want to be notified about that. Right now we have a "Update all submodules after pulling changes from the remote repository" option who will do that, but we miss the notification part. A decorator on the pull button, perhaps.

AlexJitianu avatar May 16 '22 06:05 AlexJitianu

Hi Alex, we don't have separate roles like that for the most part. Our writers document complex software that manages telecom networks, and most have engineering degrees. If a submodule is associated with a git tag on a specific commit in the target repo, they'd want to know if there were any new tags with commits with a later date compared to the current one.

This was some of the motivation for me mocking up a proposed Branch Manager view and sending it to you guys, which incorporated git tags and submodules as well so all these aspects could appear in the same view.

kirkilj avatar May 23 '22 00:05 kirkilj