oxyc

Results 45 comments of oxyc

Can't recall unfortunately and don't have access to test it at the moment. There's [quite a few plugins](https://github.com/search?q=%22%24handler%5B%27callback%27%5D%5B0%5D%22+WP_REST_Posts_Controller&type=code) that does this too so I'm guessing it was just from inspecting...

> Call to undefined function Illuminate\Foundation\Console\base_path() Seems to be an upstream issue in roots/acorn.

Thanks for reporting it upstream and linking it @tombroucke. I'll leave this issue open until acorn/next is released since it's currently still a documentation issue in the README of this...

Yeah, that would probably make it easier. Just realized that making this change would break all existing composer dependency setups as the old `Vagrantfile` will be overridden and the `DRUPALVM_CONFIG_DIR`...

Only example I've seen that breaks out the logic is homestead. https://github.com/laravel/homestead/blob/master/Vagrantfile https://github.com/laravel/homestead/blob/master/scripts/homestead.rb

This is what it would look like if we dropped support for a delegating Vagrantfile. Edit: Added a commit so it's easier to read. I can always revert it. If...

- [x] approval - [x] update docs - [ ] should we include tests for the composer plugin? - [x] way more readable logic

> Also, with the Vagrantfile ever-expanding in size, I wonder if it might be good to have a 'ruby-src subfolder somewhere (something like that... whatever the Ruby convention would be)...

Yeah I agree this should be saved for 5.0. Btw, is there a way to detect which version you're updating from in a composer plugin? If it is, we could...

I came pretty far and managed to detect updates from