megalinter icon indicating copy to clipboard operation
megalinter copied to clipboard

Possible futur issue with MarkdownLint

Open llaville opened this issue 1 year ago • 1 comments

Hello ML team,

I've just upgraded my version of MegaLinter from v6.22.2 to v7.8.0; I know I'm late on migration ;-)

I just got a warning that perharps will become an issue, if we can't check it !

✅ Linted [MARKDOWN] files with [markdownlint]: Found 3 non blocking error(s) - (2.06s)
- Using [markdownlint v0.38.0] https://megalinter.io/7.8.0/descriptors/markdown_markdownlint
- MegaLinter key: [MARKDOWN_MARKDOWNLINT]
- Rules config: [.markdownlint.json]
- Number of files analyzed: [25]
--Error detail:
CHANGELOG-7.x.md:29:54 MD034/no-bare-urls Bare URL used [Context: "https://github.com/nikic/PHP-P..."]
(node:36) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
(Use `node --trace-deprecation ...` to show where the warning was created)

As MarkdownLint-CLI is installed with NPM, I suppose the node warning came from here.

Just wanted to notify ML team, because I don't have time to check on it !

After fixing error on my repo (CHANGELOG-7.x.md), I re-run ML and got no more error

✅ Linted [MARKDOWN] files with [markdownlint] successfully - (1.52s)
- Using [markdownlint v0.38.0] https://megalinter.io/7.8.0/descriptors/markdown_markdownlint
- MegaLinter key: [MARKDOWN_MARKDOWNLINT]
- Rules config: [.markdownlint.json]
- Number of files analyzed: [25]

llaville avatar Feb 08 '24 10:02 llaville

I don't understand how it can happen... the npm warnings are supposed to happen during installation, not during process :(

nvuillam avatar Feb 08 '24 10:02 nvuillam

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

If you think this issue should stay open, please remove the O: stale 🤖 label or comment on the issue.

github-actions[bot] avatar Mar 10 '24 00:03 github-actions[bot]

thanks @llaville (you are also ML team ^^ )

Such warning is the problem of markdownlint-cli... if someday it really doesn't work, MegaLinter auto upgrade jobs will detect it, and either we'll downgrade markdownlint, either they'll provide a fix :)

nvuillam avatar Mar 10 '24 13:03 nvuillam

No more error in same context since MegaLinter 7.9.0 ; So I'll close this report.

llaville avatar Mar 11 '24 05:03 llaville