megalinter
megalinter copied to clipboard
Correct spelling of `containername` argument.
Fixes #1570.
Proposed Changes
- Spell the new mega-linter-runner argument
container-name
for consistency with the package name, mega-linter-runner, and to spare users from needing to addcontainername
as a CSpell exception. - Remove the CSpell exception for
containername
to prove that no references were missed and as a regression test. - Make minor formatting improvements to runner.js for consistency with #1563 based on my code review feedback on #1561.
Readiness Checklist
Author/Contributor
- [x] If documentation is needed for this change, has that been included in this pull request
Reviewing Maintainer
- [ ] Label as
breaking
if this is a large fundamental change - [x] Label as either
automation
,bug
,documentation
,enhancement
,infrastructure
, orperformance
π¦ MegaLinter status: :warning: WARNING
Descriptor | Linter | Files | Fixed | Errors | Elapsed time |
---|---|---|---|---|---|
β BASH | bash-exec | 7 | 0 | 0.04s | |
β BASH | shellcheck | 7 | 0 | 0.3s | |
β BASH | shfmt | 7 | 0 | 0 | 0.28s |
β COPYPASTE | jscpd | yes | no | 2.47s | |
β DOCKERFILE | hadolint | 105 | 0 | 8.05s | |
β JSON | eslint-plugin-jsonc | 21 | 0 | 0 | 2.4s |
β JSON | jsonlint | 19 | 0 | 0.25s | |
β JSON | v8r | 21 | 0 | 18.26s | |
:warning: MARKDOWN | markdownlint | 294 | 0 | 5 | 6.53s |
β MARKDOWN | markdown-link-check | 294 | 0 | 6.43s | |
β MARKDOWN | markdown-table-formatter | 294 | 0 | 0 | 8.03s |
β OPENAPI | spectral | 1 | 0 | 0.91s | |
:warning: PYTHON | bandit | 170 | 55 | 2.87s | |
β PYTHON | black | 170 | 0 | 0 | 5.28s |
β PYTHON | flake8 | 170 | 0 | 2.41s | |
β PYTHON | isort | 170 | 0 | 0 | 0.69s |
β PYTHON | mypy | 170 | 0 | 7.8s | |
β PYTHON | pylint | 170 | 0 | 13.22s | |
:warning: PYTHON | pyright | 170 | 274 | 18.94s | |
β REPOSITORY | checkov | yes | no | 32.61s | |
β REPOSITORY | git_diff | yes | no | 0.26s | |
β REPOSITORY | secretlint | yes | no | 10.58s | |
β REPOSITORY | trivy | yes | no | 24.29s | |
β SPELL | cspell | 706 | 0 | 21.28s | |
β SPELL | misspell | 533 | 0 | 0 | 0.85s |
β XML | xmllint | 3 | 0 | 0.0s | |
β YAML | prettier | 80 | 0 | 0 | 3.22s |
β YAML | v8r | 22 | 0 | 42.24s | |
β YAML | yamllint | 81 | 0 | 1.43s |
See errors details in artifact MegaLinter reports on CI Job page
π¦ MegaLinter status: :warning: WARNING
Descriptor | Linter | Files | Fixed | Errors | Elapsed time |
---|---|---|---|---|---|
β BASH | bash-exec | 7 | 0 | 0.04s | |
β BASH | shellcheck | 7 | 0 | 0.27s | |
β BASH | shfmt | 7 | 0 | 0 | 0.03s |
β COPYPASTE | jscpd | yes | no | 1.96s | |
β DOCKERFILE | hadolint | 105 | 0 | 8.42s | |
β JSON | eslint-plugin-jsonc | 21 | 0 | 0 | 1.81s |
β JSON | jsonlint | 19 | 0 | 0.26s | |
β JSON | v8r | 21 | 0 | 15.77s | |
:warning: MARKDOWN | markdownlint | 294 | 2 | 5 | 4.95s |
β MARKDOWN | markdown-link-check | 294 | 0 | 4.96s | |
β MARKDOWN | markdown-table-formatter | 294 | 2 | 0 | 5.38s |
β OPENAPI | spectral | 1 | 0 | 0.73s | |
:warning: PYTHON | bandit | 170 | 55 | 2.45s | |
β PYTHON | black | 170 | 0 | 0 | 3.58s |
β PYTHON | flake8 | 170 | 0 | 2.18s | |
β PYTHON | isort | 170 | 0 | 0 | 0.4s |
β PYTHON | mypy | 170 | 0 | 6.98s | |
β PYTHON | pylint | 170 | 0 | 10.73s | |
:warning: PYTHON | pyright | 170 | 272 | 16.28s | |
β REPOSITORY | checkov | yes | no | 25.96s | |
:warning: REPOSITORY | devskim | yes | 59 | 1.15s | |
β REPOSITORY | dustilock | yes | no | 2.36s | |
β REPOSITORY | git_diff | yes | no | 0.04s | |
β REPOSITORY | secretlint | yes | no | 3.35s | |
β REPOSITORY | syft | yes | no | 2.0s | |
β REPOSITORY | trivy | yes | no | 17.43s | |
β SPELL | cspell | 706 | 0 | 16.04s | |
β SPELL | misspell | 533 | 2 | 0 | 0.41s |
β XML | xmllint | 3 | 0 | 0.0s | |
β YAML | prettier | 80 | 0 | 0 | 2.57s |
β YAML | v8r | 22 | 0 | 34.94s | |
β YAML | yamllint | 81 | 0 | 1.33s |
See errors details in artifact MegaLinter reports on CI Job page
You could have the same capabilities but better runtime performances if you use a MegaLinter flavor:
- oxsecurity/megalinter/flavors/python@v5 (56 linters)
@Kurt-von-Laven this would be a breaking change for people using containername argument :/
Is it worth doing in v7? I think the current unconventional spelling may cause some frustration for users who aren't yet using it. I understandably got push back from the CSpell maintainer when I proposed adding containername
to the software-terms dictionary since he couldn't find much evidence of other projects that use this spelling.
Let's have a stable v6 before thinking about v7 haha ^^ But we can write that somwhere for someday ^^
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.
If you think this pull request should stay open, please remove the O: stale π€
label or comment on the pull request.
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.
If you think this pull request should stay open, please remove the O: stale π€
label or comment on the pull request.
Codecov Report
Merging #1571 (8c2c728) into main (1708e04) will increase coverage by
0.02%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## main #1571 +/- ##
==========================================
+ Coverage 82.68% 82.71% +0.02%
==========================================
Files 157 157
Lines 3384 3384
==========================================
+ Hits 2798 2799 +1
+ Misses 586 585 -1
Impacted Files | Coverage Ξ | |
---|---|---|
megalinter/reporters/UpdatedSourcesReporter.py | 89.74% <0.00%> (+2.56%) |
:arrow_up: |
:mega: Weβre building smart automated test selection to slash your CI/CD build times. Learn more