megalinter
megalinter copied to clipboard
oxsecurity
Automatically Update editorconfig-checker
Is your feature request related to a problem? Please describe. Editorconfig-checker 2.4.0 was released on December 7th, 2021, but MegaLinter is still on editorconfig-checker 2.3.5.
Describe the solution you'd like Include editorconfig-checker in automated updates.
Describe alternatives you've considered Manually bump the version of editorconfig-checker one time.
Additional context There could very well be a good reason not to automatically update editorconfig-checker that I lack context on (e.g., perhaps it broke us in the past).
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.
If you think this issue should stay open, please remove the O: stale 🤖 label or comment on the issue.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
I am beginning to suspect this may not be a MegaLinter issue so much as editorconfig-checker/editorconfig-checker.javascript#385. We use that npm package, which wraps editorconfig-checker itself, so maybe the npm package (in conjunction with some caching on our end?) is the cause of the editorconfig-checker version remaining at 2.3.5.
It seems there is a go installer, let's try it :)
go install github.com/editorconfig-checker/editorconfig-checker/cmd/editorconfig-checker@latest
I may be overlooking the obvious, but I am reopening this issue, because the release of editorconfig-checker 2.5.0 does not appear to have been picked up by the automation. I know the Go installer was able to pick up the previous release (2.4.0) though.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.
If you think this issue should stay open, please remove the O: stale 🤖 label or comment on the issue.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.
If you think this issue should stay open, please remove the O: stale 🤖 label or comment on the issue.
@nvuillam @Kurt-von-Laven I just checked this topic and I see that it is installed via a docker image:
https://github.com/oxsecurity/megalinter/blob/main/megalinter/descriptors/editorconfig.megalinter-descriptor.yml#L28
The problem is that this image is not being updated....
https://hub.docker.com/r/mstruebing/editorconfig-checker/tags
It's on 2.4.0 and they're already on 2.6.0:
https://github.com/editorconfig-checker/editorconfig-checker/releases
Why don't we install it with go?
https://github.com/editorconfig-checker/editorconfig-checker#installation
In the case of actionlint we do it like this:
https://github.com/oxsecurity/megalinter/blob/main/megalinter/descriptors/action.megalinter-descriptor.yml#L32
@nvuillam #1830 why did you close it? I see you've tried this before....
Edit: I see... https://github.com/editorconfig-checker/editorconfig-checker/issues/220
Alternative would be to use their docker image with a fixed version then manually update it, like we already do for some linters that do not provide @latest tags ... but we would loose the automatic update :)
Example: https://megalinter.io/latest/descriptors/terraform_tflint/#installation-on-mega-linter-docker-image
https://github.com/editorconfig-checker/editorconfig-checker/issues/219 Was closed, docker image got published, and a GitHub action was added. Some pretty good maintenance was made in the last day or so.
He seems working on it today, and we see 2.7.0 out. So maybe wait for the week and see.
I was curious last weekend and told myself I'd like to play with goreleaser, a thing that seemed to block the repo and the maintainer wanted to have set up to solve a lot of problems. So I'm currently learning about it and see if I could make it work either way. Last weekend's reading had me thinking that it was a quite interesting project!
https://hub.docker.com/r/mstruebing/editorconfig-checker/tags now has tag 2.7.0 as latest. What needs to happen for this version to be used by megalinter?
A PR changing this line :) https://github.com/oxsecurity/megalinter/blob/f0fe070bfbd6e119245f6fac4f249b11c1727cb1/megalinter/descriptors/editorconfig.megalinter-descriptor.yml#L28
@rasa Do you happen to have a little Go packaging/module organization knowledge? I started working a couple weekends ago on helping that project have better CI releases, that will imply creating a v3 release, but what must be done (in regards to the namespace adding /v2 or /v3) when making major releases after v1?
See https://github.com/editorconfig-checker/editorconfig-checker/issues/204#issuecomment-1407701573, with my branch being https://github.com/echoix/editorconfig-checker/tree/dev/goreleaser
@echoix I haven't worked much with goreleaser, but I'll check out your branch and see if I can help test/debug. Let's continue the discussion in https://github.com/editorconfig-checker/editorconfig-checker/issues/204.
@rasa
@echoix I haven't worked much with goreleaser, but I'll check out your branch and see if I can help test/debug. Let's continue the discussion in https://github.com/editorconfig-checker/editorconfig-checker/issues/204.
Great! At least it's not a GoReleaser help needed, it's plain Go concepts, since it was my first time using go (but not CI)