megalinter icon indicating copy to clipboard operation
megalinter copied to clipboard

feature: add 🐊Putout (#1127)

Open coderaiser opened this issue 2 years ago • 13 comments

Fixes #1127

Proposed Changes

Added 🐊Putout linter.

  1. ...
  2. ...
  3. ...

Readiness Checklist

Author/Contributor

  • [x] If documentation is needed for this change, has that been included in this pull request

Reviewing Maintainer

  • [ ] Label as breaking if this is a large fundamental change
  • [ ] Label as either automation, bug, documentation, enhancement, infrastructure, or performance

coderaiser avatar Dec 25 '21 14:12 coderaiser

Unfortunately , MegaLinter is not able yet to share descriptors between languages, that's why for example eslint is described in javascript, jsx, typescript , tsx and json descriptor files. If you want putout to be present for all these file extensions, you'll have to:

  • add it in all related descriptors
  • add property active_only_if_file_found: [".putout.json"] ( for now I don't want putout to run by default on all repos, as it would scare users to see their code rewritten ^^ )
  • maybe enhance a little linter_text content ? it is what will appear in MegaLinter online documentation
  • run bash build.sh , as described in contribution guide, so Dockerfiles and python test classes will be automatically generated

nvuillam avatar Dec 26 '21 12:12 nvuillam

Done, thank you :)!

  • [x] fixed link to run megalinter locally
  • [x] let's start from JavaScript
  • [x] added property active_only_if_file_found: [".putout.json"]
  • [x] enhanced a little bit linter_text content
  • [x] run bash build.sh

Thanks for detailed explanation, I never contributed to python projects, but things was straight forward :)!

coderaiser avatar Dec 26 '21 19:12 coderaiser

Thanks for your updates, now let's see what CI says :)

nvuillam avatar Dec 26 '21 22:12 nvuillam

It says that it cannot find the image:

1) CLI
78
       (CLI) run on own code base:
79
     Error: Command failed: mega-linter-runner --path ./.. --release test-nvuillam-merge -e "ENABLE=YAML" --nodockerpull
80
Unable to find image 'megalinter/megalinter:test-nvuillam-merge' locally
81
docker: Error response from daemon: manifest for megalinter/megalinter:test-nvuillam-merge not found: manifest unknown: manifest unknown.
82
See 'docker run --help'.
83

And something with spell, maybe this is the link I fixed in documentation 🤔

coderaiser avatar Dec 28 '21 10:12 coderaiser

part of CI is broken... not your fault , and not even mine ^^ It will finally work sometime ^^

nvuillam avatar Dec 29 '21 16:12 nvuillam

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

If you think this pull request should stay open, please remove the O: stale 🤖 label or comment on the pull request.

github-actions[bot] avatar Jan 29 '22 00:01 github-actions[bot]

@nvuillam do you have any progress on this?

coderaiser avatar Feb 09 '22 09:02 coderaiser

@coderaiser not yet sorry (lack of free time/priorities) but I unstaled to not forget :)

nvuillam avatar Feb 09 '22 09:02 nvuillam

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

If you think this pull request should stay open, please remove the O: stale 🤖 label or comment on the pull request.

github-actions[bot] avatar Mar 12 '22 00:03 github-actions[bot]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

If you think this pull request should stay open, please remove the O: stale 🤖 label or comment on the pull request.

github-actions[bot] avatar Apr 27 '22 01:04 github-actions[bot]

Any progress on this?

coderaiser avatar Sep 22 '22 13:09 coderaiser

CI just passed for me, so I am curious to see what happens if we re-run it.

Kurt-von-Laven avatar Sep 22 '22 13:09 Kurt-von-Laven

Looks like it needs a rebase first though.

Kurt-von-Laven avatar Sep 22 '22 13:09 Kurt-von-Laven

Done.

coderaiser avatar Sep 22 '22 19:09 coderaiser

Looks like CI found two test failures and one misspelling that are specific to this branch.

Kurt-von-Laven avatar Sep 23 '22 09:09 Kurt-von-Laven

Just fixed spell, could you please help me with tests

coderaiser avatar Sep 23 '22 10:09 coderaiser

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

If you think this pull request should stay open, please remove the O: stale 🤖 label or comment on the pull request.

github-actions[bot] avatar Oct 24 '22 01:10 github-actions[bot]

ping @Kurt-von-Laven

coderaiser avatar Oct 24 '22 05:10 coderaiser