DataDeps.jl icon indicating copy to clipboard operation
DataDeps.jl copied to clipboard

display download progress bar

Open CarloLucibello opened this issue 2 years ago • 2 comments

It is useful when downloading large datasets.

CarloLucibello avatar May 09 '22 05:05 CarloLucibello

Do you mean for 1 file or for multiple files? For 1 file this issue needs to be openned on HTTP.jl as we use HTTP.download to do the download. (unless you pass in a different fetch_method) When I updated HTTP.download I had progress logging working: https://github.com/JuliaWeb/HTTP.jl/blob/7cab2ab077825aff366cc8e1e34db9d5566654bd/src/download.jl#L134 AFAICT It is still ProgressLogging.jl compatible. Which means if you use Juno (pretty sure i tested this) or TerminalLoggers.jl a progress bar will show up rather than a %

For multiple files we could display a progress bar for the overall, in this package.

oxinabox avatar May 12 '22 18:05 oxinabox

Hey @oxinabox,

I opened an issue over HTTP.jl - hopefully I didn't butcher what you were discussing here but I would find this feature quite helpful. Thanks for the great package again!

P.S. Hopefully this addresses the comments also found in https://github.com/oxinabox/DataDeps.jl/issues/145 https://github.com/oxinabox/DataDeps.jl/issues/114 and https://github.com/oxinabox/DataDeps.jl/issues/109

TheCedarPrince avatar Sep 08 '22 15:09 TheCedarPrince