COSMO.jl
COSMO.jl copied to clipboard
#127 fix: support cones for generic number types.
Hey,
This should solve #127 , at least it allows me to run ( and obtain correct result) in the exemples from @migarstka, but also on my own application (fixing matrices that should be SDP in a certain moment problem), that could become a test.
This includes a dependency to GenericLinearAlgebra.
The code is allocating, I tried MutableArithmetics but it did not work.
This is probably suboptimal, since the ws
variable is not needed anymore it could be removed to free space, but it'll make the code less readable.
Todo :
- [x] Check results on @migarstka 's and my exemple.
- [ ] Eventually find a non-allocative
eigen
function inGenericLinearAlgebra
- [x] Find the right function in MutableArithmetics to avoid allocations.
- [ ] Construct a test from my exemple & @migarstka 's one.
Thanks for submitting the PR :) I added two comments regarding the code. I am quite busy this week, but happy to add a unit test for this next week.
Thanks for taking a look, i changed some things. I did not manage to make GenericLinearAlgebra.eigen!
work though.
After @blegat fixes of type piracy at JuliaAlgebra/MultivariatePolynomials.jl#164, the code runs. The results on my use case seems to be alright for MultiFloats but not for BigFloats ! Which is crazy.
What is the problem you have for BigFloat? MultiFloats don't implement MutableArithmetics.jl