session-ios icon indicating copy to clipboard operation
session-ios copied to clipboard

Onboarding Redesign

Open RyanRory opened this issue 1 year ago • 3 comments

RyanRory avatar Aug 21 '23 06:08 RyanRory

I assume it's if it's intended but on subsequent launches the empty home screen doesn't show the "account created" UI (can't see this behaviour in the acceptance criteria or the Figma designs) - screenshot 1

So I did this on purpose. I don't think it makes sense to show the account created thing on subsequent launches or after the user cleaned all the conversations. I might forget to raise it.

RyanRory avatar Apr 04 '24 04:04 RyanRory

So I did this on purpose. I don't think it makes sense to show the account created thing on subsequent launches or after the user cleaned all the conversations. I might forget to raise it.

Yea no stress, thanks for raising it - just want to make sure all platforms behave consistently since we've gone to so much effort to try and fully define the behaviour here

mpretty-cyro avatar Apr 04 '24 06:04 mpretty-cyro

Codecov Report

Attention: Patch coverage is 0.59906% with 2323 lines in your changes missing coverage. Please review.

Project coverage is 12.32%. Comparing base (e4d07fc) to head (573e3cb). Report is 18 commits behind head on dev.

:exclamation: Current head 573e3cb differs from pull request most recent head 1726930

Please upload reports for the commit 1726930 to get more accurate results.

Files Patch % Lines
Session/Settings/RecoveryPasswordScreen.swift 0.00% 248 Missing :warning:
Session/Onboarding/LandingScreen.swift 0.00% 199 Missing :warning:
Session/Onboarding/PNModeScreen.swift 0.00% 174 Missing :warning:
...ssion/Home/New Conversation/NewMessageScreen.swift 0.00% 148 Missing :warning:
Session/Onboarding/LoadAccountScreen.swift 0.00% 147 Missing :warning:
Session/Home/HomeVC.swift 0.00% 125 Missing :warning:
...ionUIKit/Components/SwiftUI/SessionTextField.swift 0.00% 114 Missing :warning:
Session/Onboarding/LoadingScreen.swift 0.00% 112 Missing :warning:
...ome/New Conversation/StartConversationScreen.swift 0.00% 111 Missing :warning:
...on/Home/New Conversation/InviteAFriendScreen.swift 0.00% 109 Missing :warning:
... and 39 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #891      +/-   ##
==========================================
+ Coverage   12.26%   12.32%   +0.05%     
==========================================
  Files         651      654       +3     
  Lines       96623    96414     -209     
==========================================
+ Hits        11850    11882      +32     
+ Misses      84773    84532     -241     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Apr 15 '24 06:04 codecov[bot]