session-ios icon indicating copy to clipboard operation
session-ios copied to clipboard

[BUG] Close group become read-only for iOS users after a co-founder with iOS client quits the group.

Open ghost opened this issue 2 years ago • 5 comments

Code of conduct

Is there an existing issue for this?

  • [X] I have searched the existing issues

Current Behavior

When a co-founder with an iOS client quits a closed group, the closed group becomes read-only for all other group members on iOS, however, group members on a Desktop can still input into the group.

Expected Behavior

The leaving of a co-founder should not affect the write permission of any other group members.

Steps To Reproduce

  1. Create a Session account called Alice on iOS, link Alice's device to Session Desktop.

  2. Create a Session account called Bob on iOS.

  3. Create a Session account called Carol on iOS.

  4. Alice sends message requests to Bob and Carol.

  5. Bob and Carol accept the requests.

  6. Alice from iOS creates a closed group with Bob and Carol. In other words, Alice is the founder, Bob and Carol are co-founders.

  7. Bob on iOS leaves the close group.

Now, this is the first weird thing:

A dialog prompts:

Do you really want to leave? Because you are the creator of this group it will be deleted for everyone. This cannot be undone.

This is surprising because as mentioned above, Bob is not the creator. Bob is just one of the cofounders like Carol.

  1. After Bob quits the closed group:
  • Alice on iOS can no longer input to the group if she switches to the main panel and switches back to the group conversation.
  • Carol on iOS can no longer input to the group if she switches to the main panel and switches back to the group conversation.
  • However, Alice on Desktop still can input to the group. As a result, the group become read-only for Carol.
  • The group member count shown on iOS and the group member count shown on the Desktop are inconsistent. iOS shows 1 but Desktop shows 2.

iOS Version

iOS 16.1.1

Session Version

2.2.4

Anything else?

I'm aware that the dev team is working on an overhaul of the closed group feature. I'm not asking for an urgent fix, just provide this as a test case so we can revisit it when the overhaul is nearly done.

ghost avatar Dec 08 '22 13:12 ghost

close-group-no-input-ios-2022-12-09-001414

The above screenshot demonstrates what happens on Alice's iOS or Carol's iOS after Bob left the closed group: Neither Alice nor Carol can input into the group, they are in read-only mode now. The input textbox just disappeared.

ghost avatar Dec 08 '22 13:12 ghost

Screen Shot 2022-12-09 at 12 00 22 am

Despite iOS clients can no longer input into the broken closed group, Desktop clients can still input.

Also notice that the number of members shown in the same closed group is inconsistent between iOS clients and Desktop clients.

ghost avatar Dec 08 '22 13:12 ghost

Yeah we are aware of issues with closed groups getting into these states especially when users leave the group, which initiates a key rotation. We are working on our closed group overhaul currently which should address these issues

KeeJef avatar Dec 12 '22 00:12 KeeJef

@KeeJef is there any temporary workaround that you are aware of? I've tried removing and re-adding an affected user to the group, but this does not seem to fix it.

nanostos avatar Dec 19 '22 02:12 nanostos

This should not affect updated groups when #894 is released

mpretty-cyro avatar Apr 09 '24 22:04 mpretty-cyro