session-desktop icon indicating copy to clipboard operation
session-desktop copied to clipboard

Add an action panel button to mark all conversations as read.

Open ianmacd opened this issue 2 years ago • 4 comments

Contributor checklist:

By pressing the ✓ button in the action panel, the user can now mark all conversations as read.

This PR incidentally implements tool-tips for the action panel buttons, as pictured here:

markall1

On successful marking, a toast is displayed:

markall2

Fixes oxen-io/session-desktop-temp#409.

ianmacd avatar Feb 21 '23 19:02 ianmacd

I've now implemented a modal dialogue to allow the user to confirm the marking of all conversations as read.

image

ianmacd avatar Feb 23 '23 09:02 ianmacd

Generally think having a button to mark all conversations as read is a good idea, but not sure about the placement of the button in this design, the UX/UI team is going to look at some options on where we could place the button

KeeJef avatar Feb 28 '23 02:02 KeeJef

Generally think having a button to mark all conversations as read is a good idea, but not sure about the placement of the button in this design, the UX/UI team is going to look at some options on where we could place the button

I'm not married to the location I used. I placed the button in the action panel because:

  • Other such buttons already existed, so I could see at a glance how to add another;
  • The action panel is chronically underutilised. There's a lot of unused vertical space, so it seems prudent to find new purposes for it.

ianmacd avatar Mar 05 '23 21:03 ianmacd

Wanted to do a temperature check on this one to see if people still feel this is a necessary feature now that we are syncing the read status of messages. For me, this has really cut down on the need to go through conversations and mark them as read on desktop.

KeeJef avatar Mar 28 '24 06:03 KeeJef