session-android icon indicating copy to clipboard operation
session-android copied to clipboard

Video call auto rotates, when auto rotate is disabled

Open WardPearce opened this issue 2 years ago • 2 comments

Code of conduct

Describe the bug

Disabling auto rotate in my settings, doesn't disable auto rotate in video calls.

To reproduce

Steps to reproduce the behavior: Disable auto rotate, start a video call. Tilt your device slightly making it unusable.

Smartphone (please complete the following information):

  • Device: Google Pixel 6, Samsung Flip & other devices of friends.
  • OS: Android
  • 1.16.3

WardPearce avatar Jan 22 '23 11:01 WardPearce

This one we can probably add some system specific check for whether auto-rotate is enabled (not sure if it exists or what it's called off the top of my head) in the onCreate of the WebRtcCallActivity and if it is enabled only then call rotationListener.enable(), same for the disable() call in onDestroy maybe?

hjubb avatar Feb 14 '23 05:02 hjubb

@hjubb Please check my attempt at fixing this: PR

rugveddarwhekar avatar Oct 29 '23 23:10 rugveddarwhekar

Thanks for the PR. We merged in the changes and they will be made in the next available app update coming out soon.

ThomasSession avatar Jun 25 '24 00:06 ThomasSession