session-android
session-android copied to clipboard
Notification for Messages Requests
Code of conduct
- [x] I have read and agree to adhere to the Code of Conduct.
Describe the bug
The message requests don't send push notifications
To reproduce
Steps to reproduce the behavior:
- Receive a message request
Screenshots or logs
~If applicable, add screenshots or logs to help explain your problem.~
Smartphone (please complete the following information):
- Device: Mi 9T / K20
- OS: LineageOS 19-20220719-UNOFFICIAL-GMS-davinci
- Version of Session or latest commit hash: 1.16.1 (3105)
Additional context
~Add any other context about the problem here.~
The problem with this idea is someone could set up a bot to make endless Session IDs and could Spam me, if someone spam's me with message requests I definitely don't want notifications or notifications with sound enabled, if this is added it should be a optional feature with the ability to disable message request notifications in the settings
On Session desktop, i doubt that the notifications about new message requests works as I have failed to reply most requests without delay not knowing about it. It is inconvenient when you expect some friend request and this new user waits and possibly his only contact is not responding. Disabling these notifications in the preferences may be useful in case one is targeted with SPAM. UPDATE: I have found that under different account ID on same desktop computer, message request arrived.
Internally this is: https://optf.atlassian.net/browse/SES-1112
Investigation in progress.
Potentially related:
- https://github.com/oxen-io/session-android/issues/280
- https://github.com/oxen-io/session-android/issues/1320 (Huawei-specific / related to backend?)
Final PR for this issue (after 2 abandoned attempts) is: https://github.com/oxen-io/session-android/pull/1414