oxen-electron-gui-wallet
oxen-electron-gui-wallet copied to clipboard
oxen-io
[Enhancement] Give full staking rewards (e.g. 16.5 Oxen) the "Service Node" label
If you are a Service Node operator and fully deliver the 15,000 Oxen stake by yourself, the staking rewards currently show up with the label "-". Unfortunately, none of the provided transaction type filters (Incoming, Outgoing, Pending, Miner, Service Node, Governance, Stake, Failed) shows these transactions, only the "All" filter does.
I propose giving these transactions a label other than "-". Ideally they would be tagged as "Service Node", since this is what all the other, non-fully-self-provided stakes show up with and it would give a nice summary of all your staking earnings.
Of course this should also be the case for fractional rewards, when being the operator, but not providing the full stake yourself.
Is this in regards to the CSV export? "Miner" was the classification for all rewards which we recently renamed to "Reward" in https://github.com/oxen-io/oxen-core/pull/1446.
I'm not sure that "-" is intentional in this case. Could you elaborate further?
The top three transactions are rewards from shared stakes where I'm only a contributor, the last one is from one of my Service Nodes where I'm the operator. When I go to the "Miner" tab it's empty, when I go to "Service Node" only the contribution rewards show up. I don't have a tab "Reward" yet. I'm on the 1.6.0 AppImage.
Has any work been put into this yet?
Indirectly, yes: rewards are now batched, which works quite differently. Have you tried this on the latest version?
Yes, the behaviour is still exactly the same. Batched rewards also get the "-" label.
Also, something I just noticed: If you unlock a stake from a SN, the transaction gets the "Failed" label, although it clearly isn't a failed transaction, but a successful one.