oxen-electron-gui-wallet icon indicating copy to clipboard operation
oxen-electron-gui-wallet copied to clipboard

Published 20 hours ago • verified publisher icon oxen-io

Decrypt ONS Records for external addresses

Open Prophet-26 opened this issue 4 years ago • 2 comments
trafficstars

The button to Decrypt ONS records disappears after an ONS record is added rendering it impossible to decrypt any more records.

image

Prophet-26 avatar May 05 '21 06:05 Prophet-26

For more context, it should show.

Screen Shot 2021-05-05 at 4 07 31 pm

kylezs avatar May 05 '21 06:05 kylezs

So it appears that the wallet in this case is working as designed. The ONS names that can be decrypted by the GUI wallet are those that belong to the wallet (ons name owner = current wallet address) and once those have been decrypted the wallet hides the decrypt form.

In this situation Prophet-26 has "Wallet A" which is owner of realsexycyborg and stream.loki. Prophet-26 would like to decrypt an ONS record owned by "Wallet B" (which also belongs to Prophet-26) however because "Wallet A" has already decrypted 2/2 ONS records that belong to "Wallet A" the decrypt form disappears.

After a quick investigation it seems like searching for an address that is not owned by the wallet will fail, so a quick removal of logic that hides the form will not be sufficient.

Screenshot from 2021-05-24 09-51-48

This potentially is a feature that could be beneficial to have and might not be too much effort to implement. But right now the search only checks the wallets internal list of addresses that it know owns.

@kylezs thoughts?

darcys22 avatar May 24 '21 00:05 darcys22