oxc icon indicating copy to clipboard operation
oxc copied to clipboard

perf(parser): pre-allocate enough space in ArrayExpression and ObjectExpressions conversion

Open Dunqing opened this issue 9 months ago • 4 comments

Dunqing avatar Mar 14 '25 08:03 Dunqing


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Dunqing avatar Mar 14 '25 08:03 Dunqing

CodSpeed Performance Report

Merging #9776 will not alter performance

Comparing 03-14-perf_parser_pre-allocate_enough_space_in_arrayexpression_and_objectexpressions_conversion (f225ca4) with main (ea7e3f0)

Summary

✅ 33 untouched benchmarks

codspeed-hq[bot] avatar Mar 14 '25 08:03 codspeed-hq[bot]

Merge activity

  • Mar 14, 5:06 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Mar 14, 5:06 AM EDT: A user added this pull request to the Graphite merge queue.
  • Mar 14, 9:12 AM UTC: The Graphite merge queue couldn't merge this PR because it was in draft mode.

Boshen avatar Mar 14 '25 09:03 Boshen

I've triggered the benchmark a few times, and from the benchmark result, it turns out this is a deoptimization. I will dig into it a little later.

Dunqing avatar Mar 14 '25 11:03 Dunqing

Closing as no notable performance improvement

Dunqing avatar May 16 '25 08:05 Dunqing