oxc
oxc copied to clipboard
fix(parser): do not double-parse modifiers of ts index signature in class
Modifiers of ts index signatures in classes are parsed twice. The first one is ignored and the second one is always empty, causing the incorrect readonly and span in ast. https://oxc-project.github.io/oxc/playground/?code=3YCAAICvgICAgICAgICxG4jI43W9aqTWr3Wzy1UcIvgVm0uDVLP%2FHYReSN%2FJ0Mhppm0XIo%2F7DW7cd39qCwCA
Your org has enabled the Graphite merge queue for merging into main
Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.
You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.
I'm curious what project you are working on with oxc 😄
CodSpeed Performance Report
Merging #6985 will not alter performance
Comparing branchseer:idxsig-modifer-span (8e655d6) with main (4b450cc)
Summary
✅ 30 untouched benchmarks
I'm curious what project you are working on with
oxc😄
Just experimenting something 😄. Don't wanna spoil it now because I'm not sure if it's even viable. But if it is, I will surely let you guys know.
Conformance tests say static is also valid for ts index signature. parser and ast updated.