oxc icon indicating copy to clipboard operation
oxc copied to clipboard

fix(parser): do not double-parse modifiers of ts index signature in class

Open branchseer opened this issue 1 year ago • 5 comments
trafficstars

Modifiers of ts index signatures in classes are parsed twice. The first one is ignored and the second one is always empty, causing the incorrect readonly and span in ast. https://oxc-project.github.io/oxc/playground/?code=3YCAAICvgICAgICAgICxG4jI43W9aqTWr3Wzy1UcIvgVm0uDVLP%2FHYReSN%2FJ0Mhppm0XIo%2F7DW7cd39qCwCA

branchseer avatar Oct 28 '24 15:10 branchseer

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

graphite-app[bot] avatar Oct 28 '24 15:10 graphite-app[bot]

I'm curious what project you are working on with oxc 😄

Boshen avatar Oct 28 '24 15:10 Boshen

CodSpeed Performance Report

Merging #6985 will not alter performance

Comparing branchseer:idxsig-modifer-span (8e655d6) with main (4b450cc)

Summary

✅ 30 untouched benchmarks

codspeed-hq[bot] avatar Oct 28 '24 15:10 codspeed-hq[bot]

I'm curious what project you are working on with oxc 😄

Just experimenting something 😄. Don't wanna spoil it now because I'm not sure if it's even viable. But if it is, I will surely let you guys know.

branchseer avatar Oct 28 '24 15:10 branchseer

Conformance tests say static is also valid for ts index signature. parser and ast updated.

branchseer avatar Oct 28 '24 16:10 branchseer