oxc icon indicating copy to clipboard operation
oxc copied to clipboard

feat(language_server): Add code actions to disable rules for the current line or entire file

Open nrayburn-tech opened this issue 1 year ago • 1 comments

This definitely needs some cleanup by somebody more familiar with Rust, but I think it contains most of the important pieces. I'll leave a review with the different pieces that I know need cleanup.

Ref #6966.

nrayburn-tech avatar Oct 27 '24 21:10 nrayburn-tech

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

graphite-app[bot] avatar Oct 27 '24 21:10 graphite-app[bot]

Made some updates to this and added some TODOs in the code. I'm not sure the TODOs are something that can easily be resolved in this PR. I think they require larger changes.

So, this could probably be merged in as is (somebody may want to cleanup the code, but I think it hits the functional parts) or leave this as a draft and make some other PRs so that the TODOs can be resolved and then merge this in.

nrayburn-tech avatar Nov 09 '24 23:11 nrayburn-tech

@Sysix can you help and get this merged.

Boshen avatar Nov 25 '24 08:11 Boshen

Do we have a consensus on this PR?

Boshen avatar Nov 26 '24 14:11 Boshen

I think so. I’ve got one bug to fix in it and I need to get it rebased.

Hopefully I’ll get to it by end of day tomorrow.

nrayburn-tech avatar Nov 26 '24 14:11 nrayburn-tech

I think so. I’ve got one bug to fix in it and I need to get it rebased.

Hopefully I’ll get to it by end of day tomorrow.

Thank you.

Boshen avatar Nov 26 '24 15:11 Boshen

Should be ready now, including the bug fix for the issue mentioned by @Sysix.

nrayburn-tech avatar Nov 26 '24 23:11 nrayburn-tech

Thanks you @nrayburn-tech, will look tomorrow on it :)

Sysix avatar Nov 26 '24 23:11 Sysix