oxc icon indicating copy to clipboard operation
oxc copied to clipboard

Alter signature of `GetAddress::address`

Open overlookmotel opened this issue 3 months ago • 0 comments

GetAddress::address currently takes a &self.

https://github.com/oxc-project/oxc/blob/262b2ed1ce890851b8aef07738a9b6f32d724463/crates/oxc_allocator/src/address.rs#L31-L34

Make it take self instead and implement it on &Box<T> instead of Box<T>. This would allow a better implementation for Copy types like Ancestor.

I think that's a good idea...

overlookmotel avatar Oct 25 '24 14:10 overlookmotel