oxc icon indicating copy to clipboard operation
oxc copied to clipboard

test(minifier): add variable collapsing test cases

Open DonIsaac opened this issue 1 year ago • 3 comments

Add test cases for the variable declaration collapsing AST pass

DonIsaac avatar Oct 01 '24 17:10 DonIsaac

[!WARNING] This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite. Learn more

  • #6227 Graphite 👈
  • #6226 Graphite
  • main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @DonIsaac and the rest of your teammates on Graphite Graphite

DonIsaac avatar Oct 01 '24 17:10 DonIsaac

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

graphite-app[bot] avatar Oct 01 '24 17:10 graphite-app[bot]

CodSpeed Performance Report

Merging #6227 will not alter performance

Comparing don/10-01-test_minifier_add_variable_collapsing_test_cases (3d03f87) with don/10-01-fix_minifier_collapse_variables_when_join_vars_option_is_true (ea896ec)

Summary

✅ 29 untouched benchmarks

codspeed-hq[bot] avatar Oct 01 '24 17:10 codspeed-hq[bot]

It seems that we should not put it separately in a file. See https://github.com/oxc-project/oxc/pull/5912

BTW, I am curious about where these test cases came from. Shouldn't we prioritize copying them from the closure-compiler? See this 🤔

shulaoda avatar Oct 07 '24 12:10 shulaoda