oxc icon indicating copy to clipboard operation
oxc copied to clipboard

feat(oxlint): implement `--print-config` cli option

Open nicksrandall opened this issue 1 year ago • 9 comments

I've attempted to implement --print-config for oxlint. This implementation works but I'm almost certain there is a better way to do this and I'm open to feedback.

See discussion: #4279

nicksrandall avatar Aug 07 '24 20:08 nicksrandall

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

graphite-app[bot] avatar Aug 07 '24 20:08 graphite-app[bot]

This looks related to #4720. I'd like to reach consensus there before we merge this.

DonIsaac avatar Aug 07 '24 22:08 DonIsaac

The cli can get merged first because it's a eslint command.

Behavior wise I think it should just print out whatever is read, it doesn't matter whether it's v8 or v9.

Boshen avatar Aug 08 '24 02:08 Boshen

If ESLint supports it then we should too.

DonIsaac avatar Aug 08 '24 04:08 DonIsaac

@nicksrandall it appears CI checks are not passing, let me know when you're ready for a review.

DonIsaac avatar Aug 08 '24 04:08 DonIsaac

@DonIsaac I believe I'm ready for review. Thanks you!

nicksrandall avatar Aug 08 '24 19:08 nicksrandall

CodSpeed Performance Report

Merging #4742 will not alter performance

Comparing nicksrandall:main (0ecdf4e) with main (a105df3)

Summary

✅ 29 untouched benchmarks

codspeed-hq[bot] avatar Aug 08 '24 19:08 codspeed-hq[bot]

I'm not sure why the tests are failing... there must be some issue when a struct implements "Serialize" and "JsonSchema" traits? Any idea on how I can fix ?

nicksrandall avatar Aug 09 '24 00:08 nicksrandall

Tests are failing because there are schema snapshots that need updating. Have you run cargo test and committed the changes?

DonIsaac avatar Aug 09 '24 05:08 DonIsaac

Hi! @nicksrandall Do you mind me taking this?

mysteryven avatar Oct 10 '24 23:10 mysteryven

Please do!

nicksrandall avatar Oct 10 '24 23:10 nicksrandall

Close in favor of #6579

mysteryven avatar Oct 23 '24 00:10 mysteryven