oxc icon indicating copy to clipboard operation
oxc copied to clipboard

feat(coverage): enable regexp in test262

Open Boshen opened this issue 1 year ago • 5 comments

@leaysgur This enables all test262 regexp tests, feel free to decide when's the right time to integrate.

It seems like we need to add some pointing spans on the diagnostics.

It's somewhat slow to run just c, so I always use just example parser for local development.

Boshen avatar Jul 13 '24 03:07 Boshen

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

graphite-app[bot] avatar Jul 13 '24 03:07 graphite-app[bot]

CodSpeed Performance Report

Merging #4242 will not alter performance

Comparing regexp-tests (33c80a7) with regexpp (bb54e3a)

Summary

✅ 29 untouched benchmarks

codspeed-hq[bot] avatar Jul 13 '24 03:07 codspeed-hq[bot]

feel free to decide when's the right time to integrate.

It looks like it will take a little longer, but understood. Thank you!

And I will catch up with the content of this PR as well. (BTW, I will be on an early summer vacation next week and will be unavailable. 🏖️ )

leaysgur avatar Jul 13 '24 10:07 leaysgur

FYI:

  • The previous CodSpeed result was one where the entire source code(!) was passed to the regexp parser, not the regular expression part
  • I have not yet been started parser perf improvements

Benchmark results have been updated now.

I don't think current approach is not the best solution, but the CI is green. 😅

leaysgur avatar Aug 06 '24 13:08 leaysgur

FYI:

  • The previous CodSpeed result was one where the entire source code(!) was passed to the regexp parser, not the regular expression part
  • I have not yet been started parser perf improvements

Thanks for your explanation

IWANABETHATGUY avatar Aug 06 '24 14:08 IWANABETHATGUY

Continue in https://github.com/oxc-project/oxc/pull/4998

Boshen avatar Aug 20 '24 07:08 Boshen