oxc icon indicating copy to clipboard operation
oxc copied to clipboard

feat(linter): eslint-plugin-jest/valid-expect-in-promise

Open eryue0220 opened this issue 9 months ago • 5 comments

part of https://github.com/oxc-project/oxc/issues/492

Rule Detail: link

The last recommend rules of eslint-plugin-jest. But there're still many test cases to fix.

eryue0220 avatar Apr 30 '24 15:04 eryue0220

CodSpeed Performance Report

Merging #3146 will improve performances by 4.92%

Comparing eryue0220:feat/jest-valid-expect-in-promise (b54aa95) with main (bb995f6)

Summary

⚡ 1 improvements ✅ 28 untouched benchmarks

Benchmarks breakdown

Benchmark main eryue0220:feat/jest-valid-expect-in-promise Change
transformer[cal.com.tsx] 12.2 ms 11.6 ms +4.92%

codspeed-hq[bot] avatar Apr 30 '24 15:04 codspeed-hq[bot]

@eryue0220 any updates on this PR?

DonIsaac avatar Jul 31 '24 02:07 DonIsaac

@eryue0220 any updates on this PR?

No, previously @mysteryven said that something may will change in jest rule, and can continue to implement other jest's rules except valid-expect-in-promise.

More detail: https://github.com/oxc-project/oxc/pull/3358#issuecomment-2119649800

eryue0220 avatar Jul 31 '24 15:07 eryue0220

any updates on this PR?

I am lack of time recently, you are welcome to continue working on it if you like. 😁

mysteryven avatar Aug 01 '24 00:08 mysteryven

any updates on this PR?

I am lack of time recently, you are welcome to continue working on it if you like. 😁

Okay, I'll back for this PR later.

eryue0220 avatar Aug 01 '24 02:08 eryue0220