refactor(formatter): revert all changes from removing `AstKind::Argument`

[Dunqing]

[Dunqing]

• #15764
• #15762
• #15760
• #15676
• #15675 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq[bot]]

CodSpeed Performance Report

Merging #15675 will not alter performance

_{Comparing 11-12-refactor_formatter_revert_all_changes_from_removing_astkind_argument (4682dc9) with main (85c27c8)[^unexpected-base]} [^unexpected-base]: No successful run was found on main (96eddce) during the generation of this report, so 85c27c8 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

Summary

✅ 33 untouched
⏩ 4 skipped[^skipped]

[^skipped]: 4 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

[Dunqing]

@taearls, I am sad to say I am going to revert them, as I found that even the changes fixed all of the prettier tests. However, they are not the ideal way, and they introduced more problems. So, to avoid wasting time correcting them one by one, I decided to revert them and re-fix them. If you are interested in how I fix them, see #15676. Anyway, I really appreciate your work! This is not an easy task, but you already did a good job!

[graphite-app[bot]]

Merge activity

• Nov 17, 7:52 AM UTC: leaysgur added this pull request to the Graphite merge queue.
• Nov 17, 8:01 AM UTC: Merged by the Graphite merge queue.

[taearls]

@taearls, I am sad to say I am going to revert them, as I found that even the changes fixed all of the prettier tests. However, they are not the ideal way, and they introduced more problems. So, to avoid wasting time correcting them one by one, I decided to revert them and re-fix them. If you are interested in how I fix them, see #15676. Anyway, I really appreciate your work! This is not an easy task, but you already did a good job!

I understand. No worries! Your changes are much cleaner and better integrated into the existing architecture, so I get it. I'll keep these patterns in mind for future work. Thanks for sharing