esphome-stream-server icon indicating copy to clipboard operation
esphome-stream-server copied to clipboard

Published 20 hours ago • verified publisher icon oxan

Add `binary_sensor`

Open joshuaspence opened this issue 3 years ago • 3 comments

Fixes #8. Based on https://github.com/thegroove/esphome-zbbridge/blob/main/custom_components/serial_server/binary_sensor.py.

joshuaspence avatar Jan 18 '22 22:01 joshuaspence

@oxan Anything else needed before we can merge this?

joshuaspence avatar Jan 30 '22 23:01 joshuaspence

Looks good!

ruimarinho avatar May 15 '22 22:05 ruimarinho

@oxan are you still interested in this change?

joshuaspence avatar Jul 02 '22 04:07 joshuaspence

This is a much needed feature!

akalagov avatar Dec 09 '22 17:12 akalagov

Hi! Sorry for the silence, I've neglected this project quite a bit over the last year.

Tonight I've finally finished the major refactoring to port to ESPHome's socket abstractions, which is in PR #25. I've also squashed this PR into that branch, albeit somewhat refactored to not create the binary sensor as a separate component. I want to do some more testing over the weekend, but if that succeeds I'll merge that one into master and we're finally done with this. Thanks for your contribution in any case!

oxan avatar Feb 03 '23 01:02 oxan

The functionality from this PR has been merged with #25.

oxan avatar Feb 07 '23 21:02 oxan