Oxan van Leeuwen comments

Results 69 comments of


                                            Oxan van Leeuwen

Fix partial update for waveshare 2in9 v2

Could you either merge dev into your branch, or rebase it on dev, to fix the merge conflict? That would allow CI to run.

Breaks transitions when turning lights on

Yeah, I was afraid so :( However, I had another idea (without looking too much at the code). I can of course set the initial color temperature myself using the...

Populate help_text on serializer

No, this currently isn't supported, though I'm not opposed to adding it.

[Feature request] Use `typing.Annotated` to redefine field types

> Without checking for Annotated types, I got this error: I don't think this has anything to do with `Annotated` types, but instead with `InMemoryUploadedFile` not being a recognized type....

[Feature request] Use `typing.Annotated` to redefine field types

> It is also possible with `Annotated` because it's not an annotation, but an instance of the field itself: Ah yeah, that's true, though it's a bit more limited, as...

add xiaomi mccgq02hl

> any chance this pr will be merged? thx Someone needs to fix my review comments & test whether it still works.

TYPE_CHECKING imports result in error on type evaluation

The problem isn't getting the type hints, it's assigning meaning to them. In your example, the `_get_type_hints()` function will just return the string `X`. How can the serializer know which...

TYPE_CHECKING imports result in error on type evaluation

I guess that'd work, but I find assigning meaning to a type hint in a different location pretty ugly (and hard to maintain). If someone has a need for this,...

TYPE_CHECKING imports result in error on type evaluation

I don't think there's anything actionable for me here. Feel free to reopen or create a new issue if someone has an idea about how this could be resolved.

Nesting dataclass serializer inside regular serializer can result in <class 'rest_framework.fields.empty'> for optional fields

On second thought, we could put in the `empty` sentinel values only when partial updates are used (`partial=True`). I bet the combination of partial updates with nested serializers isn't be...