http-request-translator icon indicating copy to clipboard operation
http-request-translator copied to clipboard

Published 20 hours ago • verified publisher icon owtf

Add custom template option

Open dhruvagarwal opened this issue 8 years ago • 5 comments

This is a POC for adding a custom template. Currently this is intended to work when no language option is provided .

dhruvagarwal avatar Mar 12 '16 10:03 dhruvagarwal

@dhruvagarwal I am not really fan of this idea for 2 reasons:

  • If the user wants to use a custom template, s-he can write it under './templates/'
  • If the user has to write the template under './templates/', it would increase the chances for them to create a PR in order to add their templates in the repo (imo).

What do you think? @arunk-s any thoughts on that?

DePierre avatar Mar 13 '16 17:03 DePierre

@DePierre I think your idea of writing the templates under a global directory sounds awesome, it will help us further in discovering the ways the users are using our tool, may be discover some bugs in our templates/code may be.

arunk-s avatar Mar 13 '16 17:03 arunk-s

@dhruvagarwal Do you think that you could add unittests for that new feature as well as the source code? That will be very helpful before merging the changes :)

DePierre avatar Mar 15 '16 22:03 DePierre

@dhruvagarwal Reading the modification, what happens if the user specifies a custom template bash.py? Is it overidden by the default one http_request_translator provides?

DePierre avatar Mar 15 '16 22:03 DePierre

@dhruvagarwal Do you need more information in order to update your PR regarding the custom template idea?

DePierre avatar Apr 06 '16 12:04 DePierre