toolbox-vscode icon indicating copy to clipboard operation
toolbox-vscode copied to clipboard

Default to standard code behaviour when outside a container

Open crispyricepc opened this issue 3 years ago • 4 comments

crispyricepc avatar Feb 21 '22 12:02 crispyricepc

I belive the verification if the user is on the host or inside a container should happen before the install prompt. Since the installation is checked with flatpak-spawn, it will fail on the host even if VSCode flatpak is already installed.

After this verification is done, we can check for the install, and later check if we should execute the VSCode flatpak on the host simply with flatpak run.

guerra08 avatar Jun 25 '22 00:06 guerra08

Is this MR still active? I have a working branch at 1886024339f80290a641902a40145840d9337f49 that I believe correctly implements the requested changes. I could make an MR for that, but I don't want to steal @crispyricepc's thunder :-)

velsinki avatar May 24 '23 20:05 velsinki

Lol I completely forgot about this. Feel free to close

crispyricepc avatar May 24 '23 20:05 crispyricepc

Haha, okay. I am not entirely sure if @owtaylor is still working on this repo though?...

velsinki avatar May 24 '23 20:05 velsinki