fpga-fft icon indicating copy to clipboard operation
fpga-fft copied to clipboard

'fft4_large_scale_div_sqrt_n' is not defined

Open dcaruso opened this issue 4 years ago • 5 comments

Hi, first thanks for your work! I tried to use it, but I found a problem when try to run the generator:

$ ./gen_fft.py fft fft1024_wide                                                                                                      
Traceback (most recent call last):
  File "./gen_fft.py", line 8, in <module>
    from gen_fft_layouts import *
  File "/fpga-fft/codegen/gen_fft_layouts.py", line 119, in <module>                                                                                          
    fft4_large_scale_div_sqrt_n),
NameError: name 'fft4_large_scale_div_sqrt_n' is not defined

This value is not defined in the gen_fft_layouts.py code.

Best!

dcaruso avatar Nov 25 '20 11:11 dcaruso

Unfortunately this issue has not yet been resolved.

1chor avatar Feb 18 '21 08:02 1chor

Same here. Too bad this project is unusable without it!

streamradiopi avatar Dec 13 '22 20:12 streamradiopi

This issue is a bit aged, and perhaps folks figured it out, but I would deeply disagree that the project is "unusable" because it doesn't support a few of the example layouts. This was pretty easy to fix, and honestly, if anyone has a hard time getting the "code to work" because of this, I'm not sure they know what they're looking at. These are FFT "architecture" descriptions. Just comment out the architectures that aren't working and if you need that particular FFT, create a new layout that supports it.

aikijw avatar Jun 14 '23 19:06 aikijw

The project should be usable without users also becoming developers of the project. I would advise anyone looking at this to instead consider SGen.

paul-demo avatar Jun 14 '23 19:06 paul-demo

I'm sorry... I just don't have words. This is github. The code is open source. The documentation clearly indicates how to fix this problem (and I fixed it in < 30 seconds before I read the documentation). Thanks to the author for building such an awesome tool. I didn't have to become a "developer of the project" (very dramatic, BTW). It just took domain knowledge and an editor. (not even very much domain knowledge. I only had one hand on the keyboard. The other hand was busy pouring espresso into my mouth) It's a VHDL code generator. [SMH] SGen will not generate a compact high performance FFT core like this tool does. Trust me. It's not the same. To the author... Thank you! Very well done! I may fork your work and add automatic testbench generation. I guess I had words after all...

aikijw avatar Jun 15 '23 05:06 aikijw