android icon indicating copy to clipboard operation
android copied to clipboard

Move monitoring mode behavior inconsistent with documentation

Open LINKIWI opened this issue 6 years ago • 2 comments

The documentation claims:

In move mode, the app monitors location permanently and publishes a new location as soon as the device moves x meters or after t seconds, whatever happens first. x and t can be adjusted by the user in the systems settings for OwnTracks.

I was looking through the app to find where to configure x and t, but only found the locator interval and locator displacement. However, changing these parameter values did not seem to have any effect.

I checked the source code to try to find the correct parameter and found that it isn't user-configurable, and also doesn't seem to use a minimum displacement update policy as suggested by the documentation:

https://github.com/owntracks/android/blob/master/project/app/src/main/java/org/owntracks/android/services/BackgroundService.java#L579

I am not an Owntracks or Android developer, so I don't claim any knowledge of any APIs. Would it be possible to just add request.setSmallestDisplacement and request.setInterval in the logic there?

LINKIWI avatar Jul 11 '19 15:07 LINKIWI

The documentation seems to be wrong and more fitting for significant mode were all parameters are configurable. Move mode just published as much as possible

binarybucks avatar Jul 11 '19 17:07 binarybucks

Would the proposed code change for request.setSmallestDisplacement and request.setInterval allow x and t to be configurable per the documentation?

LINKIWI avatar Jul 11 '19 20:07 LINKIWI