android icon indicating copy to clipboard operation
android copied to clipboard

Extract creation of marker and polygon for waypoints to remove duplicated code for OSM map

Open otwacam opened this issue 2 weeks ago • 4 comments

Extract Marker and Polygon creation for OSM map to separate functions as the functions addRegion and reDrawRegions both had effectively the same implementations with only a slight difference. The difference between them is addRegion had an additional filter so that the polygon would only be drawn if the points were valid coordinates whereas "reDrawRegions" did not have this check. This filter will now be applied in both cases.

otwacam avatar Dec 11 '25 19:12 otwacam

/run-tests

growse avatar Dec 11 '25 20:12 growse

Build & Test complete. :sparkles: View workflow run

github-actions[bot] avatar Dec 11 '25 20:12 github-actions[bot]

Just needs a little ktfmt (just format) and that'll sort the build grumble.

growse avatar Dec 11 '25 20:12 growse

Thanks for letting me know, formatted 👍

otwacam avatar Dec 11 '25 20:12 otwacam

/run-tests

growse avatar Dec 21 '25 10:12 growse

Build & Test complete. :sparkles: View workflow run

github-actions[bot] avatar Dec 21 '25 10:12 github-actions[bot]

Hmm, ktfmt still complaining. Can you doublecheck?

growse avatar Dec 21 '25 11:12 growse

Not quite sure why IDE ktfmt did not catch these. Ran formatter via CLI this time which made the changes. Should be good now hopefully.

otwacam avatar Dec 21 '25 15:12 otwacam