android icon indicating copy to clipboard operation
android copied to clipboard

Adjust contactsheet labels to be the same size as each other

Open growse opened this issue 3 years ago • 1 comments

The labels on the contactsheet previously auto-sized themselves to fit, but it was suggested in #1153 that it would look better if they were all the same size. So a little adjustment where the labels use an implementation of TextView that broadcasts the textsize after its onDraw call. Anything else that's listening to that can then adjust its size accordingly. Grouped together, all the 6 contact labels should then all be the same size.

growse avatar Aug 26 '22 14:08 growse

Codecov Report

Base: 46.36% // Head: 40.94% // Decreases project coverage by -5.42% :warning:

Coverage data is based on head (ebb4a36) compared to base (7f826be). Patch coverage: 28.16% of modified lines in pull request are covered.

:exclamation: Current head ebb4a36 differs from pull request most recent head 164a964. Consider uploading reports for the commit 164a964 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1277      +/-   ##
============================================
- Coverage     46.36%   40.94%   -5.43%     
+ Complexity     1017      882     -135     
============================================
  Files           172      173       +1     
  Lines          6731     6785      +54     
  Branches        687      693       +6     
============================================
- Hits           3121     2778     -343     
- Misses         3221     3641     +420     
+ Partials        389      366      -23     
Flag Coverage Δ
uitests 40.94% <28.16%> (-0.47%) :arrow_down:
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...n/java/org/owntracks/android/ui/map/MapActivity.kt 5.61% <24.39%> (+1.70%) :arrow_up:
...org/owntracks/android/ui/map/osm/OSMMapFragment.kt 75.94% <25.00%> (-0.45%) :arrow_down:
...android/ui/map/AutoResizingTextViewWithListener.kt 34.61% <34.61%> (ø)
.../java/org/owntracks/android/model/CommandAction.kt 0.00% <0.00%> (-100.00%) :arrow_down:
...rg/owntracks/android/model/messages/MessageCard.kt 0.00% <0.00%> (-100.00%) :arrow_down:
...ntracks/android/model/messages/MessageEncrypted.kt 0.00% <0.00%> (-100.00%) :arrow_down:
...org/owntracks/android/model/messages/MessageCmd.kt 0.00% <0.00%> (-62.50%) :arrow_down:
...g/owntracks/android/model/messages/MessageClear.kt 0.00% <0.00%> (-60.00%) :arrow_down:
...tracks/android/model/messages/MessageTransition.kt 0.00% <0.00%> (-60.00%) :arrow_down:
...rg/owntracks/android/geocoding/OpenCageGeocoder.kt 10.52% <0.00%> (-58.95%) :arrow_down:
... and 27 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Aug 26 '22 14:08 codecov[bot]