web icon indicating copy to clipboard operation
web copied to clipboard

Use share jail id from graph API instead of hardcoded id

Open kulmann opened this issue 3 years ago • 1 comments

The share jail id (needed for constructing webdav urls) has been hardcoded in https://github.com/owncloud/web/blob/51f31888dff248a8fa5e10e3c3a5c79d116f39fc/packages/web-app-files/src/services/folder/spaces/loaderShare.ts#L9

While that works, it is not a clean solution. The share jail gets populated via graph API and can be queried with drives.listMyDrives('', 'driveType eq virtual'). We should use the id of that drive instead of hardcoding it.

kulmann avatar May 09 '22 09:05 kulmann

Meanwhile moved to

packages/web-client/src/helpers/space/types.ts:export const SHARE_JAIL_ID = 'a0ca6a90-a365-4782-871e-d44447bbc668'

dragotin avatar Feb 13 '23 12:02 dragotin